Skip to content

Add gRPC support to RealtimeAPI kind #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Mar 27, 2021
Merged

Add gRPC support to RealtimeAPI kind #1997

merged 30 commits into from
Mar 27, 2021

Conversation

RobertLucian
Copy link
Member

Closes #1056.

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)
  • update examples
  • update docs and add any new files to summary.md (view in gitbook after merging)

@RobertLucian RobertLucian marked this pull request as draft March 25, 2021 17:21
vishalbollu
vishalbollu reviewed Mar 26, 2021
View reviewed changes
Copy link
Contributor

@vishalbollu vishalbollu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review progress

vishalbollu
vishalbollu reviewed Mar 26, 2021
View reviewed changes
RobertLucian
RobertLucian commented Mar 26, 2021
View reviewed changes
RobertLucian
RobertLucian commented Mar 26, 2021
View reviewed changes
RobertLucian
RobertLucian commented Mar 26, 2021
View reviewed changes
RobertLucian
RobertLucian commented Mar 26, 2021
View reviewed changes
RobertLucian
RobertLucian commented Mar 26, 2021
View reviewed changes
RobertLucian
RobertLucian commented Mar 26, 2021
View reviewed changes
RobertLucian
RobertLucian commented Mar 26, 2021
View reviewed changes
RobertLucian
RobertLucian commented Mar 26, 2021
View reviewed changes
RobertLucian
RobertLucian commented Mar 26, 2021
View reviewed changes
RobertLucian
RobertLucian commented Mar 26, 2021
View reviewed changes
RobertLucian
RobertLucian commented Mar 26, 2021
View reviewed changes
@RobertLucian RobertLucian marked this pull request as ready for review March 27, 2021 04:47
@RobertLucian RobertLucian merged commit a1e2a53 into master Mar 27, 2021
@RobertLucian RobertLucian deleted the feature/grpc branch March 27, 2021 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@vishalbollu vishalbollu vishalbollu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add gRPC support to RealtimeAPI kind
2 participants
@RobertLucian @vishalbollu